Remove extra decrement of totalIP count #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days |
|
/not stale |
jdn5126
reviewed
Oct 12, 2022
jdn5126
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
Which issue does this PR fix:
Wrong computation of totalIPs
What does this PR do / Why do we need it:
The issue is because we decrement the total here -
amazon-vpc-cni-k8s/pkg/ipamd/datastore/data_store.go
Line 1224 in c7443ae
amazon-vpc-cni-k8s/pkg/ipamd/datastore/data_store.go
Line 655 in c7443ae
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
#2041
Testing done on this change:
Repro'ed the issue and fix is holding up
Secondary IP mode and 1 pod running ->
PD mode toggle ->
Deleted the pod behind secondary IP ->
Automation added to e2e:
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.